Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:fix: Improve the LiveTimeIndicator performance. #292

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

PRBaraiya
Copy link
Collaborator

Improve the LiveTimeIndicator to set the state only when the current hour and minute changes.

Description

This PR removes unnecessary rebuilds every second. Instead, it will only rebuild the timeline when the current hour or minute will change.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

None

@ParthBaraiya ParthBaraiya self-requested a review December 13, 2023 10:26
@ParthBaraiya ParthBaraiya merged commit e7768db into master Dec 13, 2023
1 check passed
@ParthBaraiya ParthBaraiya deleted the feat/improve-live-time-line-perfomance branch December 13, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants